Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] Support Qdrant sink and source connector #7299

Merged
merged 24 commits into from
Aug 30, 2024
Merged

[Feature][Connector-V2] Support Qdrant sink and source connector #7299

merged 24 commits into from
Aug 30, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Aug 2, 2024 •
edited
Loading

Description

This PR adds support for Qdrant to be used as a source/sink in SeaTunnel.

Fixes #7190

@Anush008 Anush008 marked this pull request as draft August 2, 2024 06:42
hailin0
hailin0 reviewed Aug 2, 2024
View reviewed changes
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference
#7251 (review)

...onnector-qdrant-e2e/src/test/java/org/apache/seatunnel/e2e/connector/v2/qdrant/QdrantIT.java Outdated Show resolved Hide resolved
docs/en/connector-v2/sink/Qdrant.md Show resolved Hide resolved
@github-actions github-actions bot added the CI&CD label Aug 2, 2024
@Anush008 Anush008 marked this pull request as ready for review August 7, 2024 17:51
@Hisoka-X Hisoka-X changed the title feat: Qdrant sink and source [Feature][Connector-V2] Support Qdrant sink and source connector Aug 8, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 8, 2024

Hi @Anush008 , thanks for created this PR. Please follow the guide to open github action on your fork repository. https://github.com/apache/seatunnel/pull/7299/checks?check_run_id=28499358075

@hailin0 hailin0 dismissed their stale review August 8, 2024 12:28

revert

@hailin0 hailin0 removed the reviewed label Aug 8, 2024
@davidzollo davidzollo added the First-time contributor First-time contributor label Aug 8, 2024
@Hisoka-X
Copy link
Member

Please merge from dev to retrigger github action. Thanks

Hisoka-X
Hisoka-X reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix ci before merge it. Thanks.

@Anush008
Copy link
Contributor Author

Looks like a dependency version conflict has come up.

2024-08-27T05:05:15.4732663Z [INFO] 
2024-08-27T05:05:15.4733127Z [ERROR] Errors: 
2024-08-27T05:05:15.4734201Z [ERROR]   QdrantIT.startUp:75->initQdrant:82 » NoSuchMethod 'io.grpc.NameResolverProvide...

@Hisoka-X
Copy link
Member

Please re-trigger failed CI. Thanks
image

@Anush008
Copy link
Contributor Author

Thanks a lot for the patch @Hisoka-X.
Reran the failing JDBC test.

Hisoka-X
Hisoka-X previously approved these changes Aug 29, 2024
View reviewed changes
@Hisoka-X
Copy link
Member

waiting #7531

Hisoka-X
Hisoka-X approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Anush008 !

@hailin0 hailin0 merged commit c859071 into apache:dev Aug 30, 2024
12 checks passed
@hailin0 hailin0 mentioned this pull request Sep 9, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved CI&CD connectors-v2 document e2e First-time contributor First-time contributor reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Qdrant] Support qdrant connector source/sink
4 participants
@Anush008 @Hisoka-X @hailin0 @davidzollo