Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Suport choose the start page in http paging #7180

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

Gxinge
Copy link
Contributor

@Gxinge Gxinge commented Jul 12, 2024

In this branch I added a parameter for http paging: start_page. This parameter helps us specify the start page of the page, for example I can start reading data from page 30

@Hisoka-X
Copy link
Member

Thanks @Gxinge created this PR! Seem like the github action not started right.. Could you open github action on your fork repository first?
image

@Hisoka-X Hisoka-X added First-time contributor First-time contributor feature New feature connectors-v2 labels Jul 12, 2024
@Gxinge
Copy link
Contributor Author

Gxinge commented Jul 12, 2024

yes,when you use start page, you can choose to start reading from any page.and if this parameter is not selected, the reading starts from the page one by default

@Hisoka-X
Copy link
Member

Hi @Gxinge , any update for this comment? #7180 (comment) . Feel free to ask if you encountered problem.

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 9, 2024

Please run 'mvn spotless:apply' to fix code style before commit.

@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Aug 21, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Gxinge

@Hisoka-X Hisoka-X changed the title [Feature][Connector-V2] Suport choose the home page in http paging [Feature][Connector-V2] Suport choose the start page in http paging Aug 22, 2024
@wuchunfu wuchunfu merged commit ed15f0d into apache:dev Aug 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whether the paging function of the http connector can specify the page from which to read
3 participants