-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Kafka] kafka source refactored some reader read logic #6408
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37880b7
[Improve] kafka source improve
Carl-Zhou-CN 3ca6a3b
[BugFix][Kafka] Perfect the code
Carl-Zhou-CN 30a76e5
[BugFix][Kafka] fix
Carl-Zhou-CN ad8ddf3
[Improve][Kafka] kafka source refactored some reader read logic
Carl-Zhou-CN 13e5a33
fix
Carl-Zhou-CN b3d2c41
fix
Carl-Zhou-CN bd295f0
fix
Carl-Zhou-CN 7ca3d49
fix
Carl-Zhou-CN 0607810
Merge branch 'apache:dev' into kafka-test
Carl-Zhou-CN a3827ad
fix
Carl-Zhou-CN d84dabe
fix
Carl-Zhou-CN e8ce65b
fix
Carl-Zhou-CN 65e229c
fix
Carl-Zhou-CN adec234
Merge branch 'apache:dev' into kafka-test
Carl-Zhou-CN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
...l-common/src/main/java/org/apache/seatunnel/common/utils/TemporaryClassLoaderContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.seatunnel.common.utils; | ||
|
||
public final class TemporaryClassLoaderContext implements AutoCloseable { | ||
|
||
/** | ||
* Sets the context class loader to the given ClassLoader and returns a resource that sets it | ||
* back to the current context ClassLoader when the resource is closed. | ||
* | ||
* <pre>{@code | ||
* try (TemporaryClassLoaderContext ignored = TemporaryClassLoaderContext.of(classloader)) { | ||
* // code that needs the context class loader | ||
* } | ||
* }</pre> | ||
*/ | ||
public static TemporaryClassLoaderContext of(ClassLoader cl) { | ||
final Thread t = Thread.currentThread(); | ||
final ClassLoader original = t.getContextClassLoader(); | ||
|
||
t.setContextClassLoader(cl); | ||
|
||
return new TemporaryClassLoaderContext(t, original); | ||
} | ||
|
||
private final Thread thread; | ||
|
||
private final ClassLoader originalContextClassLoader; | ||
|
||
private TemporaryClassLoaderContext(Thread thread, ClassLoader originalContextClassLoader) { | ||
this.thread = thread; | ||
this.originalContextClassLoader = originalContextClassLoader; | ||
} | ||
|
||
@Override | ||
public void close() { | ||
thread.setContextClassLoader(originalContextClassLoader); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 0 additions & 111 deletions
111
...main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this tool!