[Improve][Jdbc] Optimize the code

apache · Jul 29, 2024 · dc70d47 · dc70d47
1 parent d1f0464
commit dc70d47
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 15 deletions.
diff --git a/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/dm/DamengCatalog.java b/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/dm/DamengCatalog.java
@@ -70,14 +70,14 @@ public DamengCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + " where name='%s'", databaseName);
+        return String.format(getListDatabaseSql() + " where name = '%s'", databaseName);
     }
 
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
                 getListTableSql(tablePath.getDatabaseName())
-                        + " where OWNER = '%s' and TABLE_NAME= '%s'",
+                        + " where OWNER = '%s' and TABLE_NAME = '%s'",
                 tablePath.getSchemaName(),
                 tablePath.getTableName());
     }

diff --git a/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/iris/IrisCatalog.java b/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/iris/IrisCatalog.java
@@ -148,7 +148,7 @@ public boolean tableExists(TablePath tablePath) throws CatalogException {
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
-                getListTableSql(tablePath.getSchemaName()) + " and TABLE_NAME= '%s'",
+                getListTableSql(tablePath.getSchemaName()) + " and TABLE_NAME = '%s'",
                 tablePath.getTableName());
     }
 

diff --git a/...ain/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleCatalog.java b/...ain/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oracle/OracleCatalog.java
@@ -118,7 +118,7 @@ protected String getDatabaseWithConditionSql(String databaseName) {
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return getListTableSql(tablePath.getDatabaseName())
-                + "  and  OWNER= '"
+                + "  and  OWNER = '"
                 + tablePath.getSchemaName()
                 + "' and table_name = '"
                 + tablePath.getTableName()

diff --git a/...ain/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/psql/PostgresCatalog.java b/...ain/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/psql/PostgresCatalog.java
@@ -104,7 +104,7 @@ public PostgresCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + " where datname='%s'", databaseName);
+        return String.format(getListDatabaseSql() + " where datname = '%s'", databaseName);
     }
 
     @Override

diff --git a/...java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/redshift/RedshiftCatalog.java b/...java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/redshift/RedshiftCatalog.java
@@ -75,14 +75,14 @@ public RedshiftCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + " where datname='%s'", databaseName);
+        return String.format(getListDatabaseSql() + " where datname = '%s'", databaseName);
     }
 
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
                 getListTableSql(tablePath.getDatabaseName())
-                        + " where table_schema = '%s' and table_name= '%s'",
+                        + " where table_schema = '%s' and table_name = '%s'",
                 tablePath.getSchemaName(),
                 tablePath.getTableName());
     }
@@ -102,12 +102,12 @@ public void close() throws CatalogException {
 
     @Override
     protected String getListDatabaseSql() {
-        return "select datname from pg_database;";
+        return "select datname from pg_database";
     }
 
     @Override
     protected String getListTableSql(String databaseName) {
-        return "SELECT table_schema, table_name FROM information_schema.tables;";
+        return "SELECT table_schema, table_name FROM information_schema.tables";
     }
 
     @Override

diff --git a/...n/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/saphana/SapHanaCatalog.java b/...n/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/saphana/SapHanaCatalog.java
@@ -111,13 +111,13 @@ public SapHanaCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + " where SCHEMA_NAME='%s'", databaseName);
+        return String.format(getListDatabaseSql() + " where SCHEMA_NAME = '%s'", databaseName);
     }
 
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
-                getListTableSql(tablePath.getDatabaseName()) + " and TABLE_NAME='%s'",
+                getListTableSql(tablePath.getDatabaseName()) + " and TABLE_NAME = '%s'",
                 tablePath.getTableName());
     }
 

diff --git a/...va/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCatalog.java b/...va/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/sqlserver/SqlServerCatalog.java
@@ -70,14 +70,14 @@ public SqlServerCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + "  where name='%s'", databaseName);
+        return String.format(getListDatabaseSql() + "  where name = '%s'", databaseName);
     }
 
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
                 getListTableSql(tablePath.getDatabaseName())
-                        + "  and  TABLE_SCHEMA= '%s' and TABLE_NAME = '%s'",
+                        + "  and  TABLE_SCHEMA = '%s' and TABLE_NAME = '%s'",
                 tablePath.getSchemaName(),
                 tablePath.getTableName());
     }

diff --git a/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/xugu/XuguCatalog.java b/...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/xugu/XuguCatalog.java
@@ -126,14 +126,14 @@ public XuguCatalog(
 
     @Override
     protected String getDatabaseWithConditionSql(String databaseName) {
-        return String.format(getListDatabaseSql() + "  where DB_NAME='%s'", databaseName);
+        return String.format(getListDatabaseSql() + "  where DB_NAME = '%s'", databaseName);
     }
 
     @Override
     protected String getTableWithConditionSql(TablePath tablePath) {
         return String.format(
                 getListTableSql(tablePath.getDatabaseName())
-                        + "  where user_name= '%s' and table_name = '%s'",
+                        + "  where user_name = '%s' and table_name = '%s'",
                 tablePath.getSchemaName(),
                 tablePath.getTableName());
     }