[MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth #14797

access2rohit · 2019-04-25T08:48:16Z

Description

This PR adds large tensor test cases for 2 more ops mentioned in the title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

access2rohit · 2019-04-25T08:49:03Z

@mxnet-label-bot add [pr-awaiting-review]

access2rohit · 2019-04-25T08:49:15Z

@apeforest : please review

tests/nightly/test_large_array.py

apeforest · 2019-04-25T23:58:07Z

tests/nightly/test_large_array.py

+    data_np = data.asnumpy()
+    output = mx.nd.depth_to_space(data, 2)
+
+def test_spacetodepth():


what are you testing here?

Have added test cases to compare with numpy implementation

apeforest · 2019-04-25T23:58:09Z

tests/nightly/test_large_array.py

@@ -185,7 +186,19 @@ def test_pick():
    b = mx.nd.ones(shape=(256*35,))
    res = mx.nd.pick(a,b)
    assert res.shape == b.shape
-
+
+def test_depthtospace():


what are you testing here?

Have added test cases to compare with numpy implementation

nit: rename to test_depth_to_space

apeforest · 2019-04-25T23:58:28Z

tests/nightly/test_large_array.py

+    data = rand_ndarray(shape_inp, 'default')
+    data_np = data.asnumpy()
+    output = mx.nd.space_to_depth(data, 2)
+    mx.nd.waitall()


no need waitall here. You can use output.asnumpy()

apeforest · 2019-04-26T17:20:52Z

tests/nightly/test_large_array.py

-
+
+def test_depthtospace():
+    def f(x, blocksize):


What does this method do? Use a meaningful name.

I have updated the names of the function

apeforest · 2019-04-26T17:21:47Z

tests/nightly/test_large_array.py

+    assert_almost_equal(output.asnumpy(), expected, atol=1e-3, rtol=1e-3)
+
+def test_spacetodepth():
+    def f(x, blocksize):


What does this method do? Use a meaningful name.

I have updated the names of the function

apeforest · 2019-04-29T05:14:43Z

tests/nightly/test_large_array.py

-
+
+def test_depthtospace():
+    def depthtospace_using_numpy(x, blocksize):


nit: rename to numpy_depth_to_space

apeforest · 2019-04-29T05:15:00Z

tests/nightly/test_large_array.py

+    assert_almost_equal(output.asnumpy(), expected, atol=1e-3, rtol=1e-3)
+
+def test_spacetodepth():
+    def spacetodepth_using_numpy(x, blocksize):


nit: rename to numpy_space_to_depth

…pth_to_space and space_to_depth

access2rohit · 2019-05-08T18:42:45Z

@mxnet-label-bot add [pr-awaiting-merge]

…pth_to_space and space_to_depth (apache#14797)

marcoabreu added the pr-awaiting-review PR is waiting for code review label Apr 25, 2019

apeforest reviewed Apr 25, 2019

View reviewed changes

tests/nightly/test_large_array.py Show resolved Hide resolved

apeforest reviewed Apr 25, 2019

View reviewed changes

tests/nightly/test_large_array.py Show resolved Hide resolved

apeforest reviewed Apr 25, 2019

View reviewed changes

tests/nightly/test_large_array.py Show resolved Hide resolved

apeforest reviewed Apr 25, 2019

View reviewed changes

access2rohit force-pushed the master branch 2 times, most recently from 6937f3a to bddb90e Compare April 26, 2019 17:17

apeforest reviewed Apr 26, 2019

View reviewed changes

access2rohit force-pushed the master branch from bddb90e to a8698ab Compare April 26, 2019 17:51

apeforest reviewed Apr 29, 2019

View reviewed changes

access2rohit force-pushed the master branch from da5d79d to a022889 Compare May 6, 2019 18:38

access2rohit changed the title ~~adding large tensor support tests for depth_to_space and space_to_depth~~ [MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth May 8, 2019

[MXNET-1400] adding tests cases to verify large tensor support for de…

6bf7dc6

…pth_to_space and space_to_depth

access2rohit force-pushed the master branch from a022889 to 6bf7dc6 Compare May 8, 2019 16:42

apeforest approved these changes May 8, 2019

View reviewed changes

marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label May 8, 2019

apeforest merged commit 8dddac0 into apache:master May 9, 2019

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019

[MXNET-1400] adding tests cases to verify large tensor support for de…

7e14b79

…pth_to_space and space_to_depth (apache#14797)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth #14797

[MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth #14797

access2rohit commented Apr 25, 2019 •

edited

Loading

access2rohit commented Apr 25, 2019

access2rohit commented Apr 25, 2019

apeforest Apr 25, 2019

access2rohit Apr 26, 2019

apeforest Apr 25, 2019

access2rohit Apr 26, 2019

apeforest Apr 29, 2019

apeforest Apr 25, 2019

apeforest Apr 26, 2019

access2rohit Apr 26, 2019

apeforest Apr 26, 2019

access2rohit Apr 26, 2019 •

edited

Loading

apeforest Apr 29, 2019

apeforest Apr 29, 2019

access2rohit commented May 8, 2019



		def test_depthtospace():
		def depthtospace_using_numpy(x, blocksize):

[MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth #14797

[MXNET-1400]adding large tensor support tests for depth_to_space and space_to_depth #14797

Conversation

access2rohit commented Apr 25, 2019 • edited Loading

Description

Checklist

Essentials

access2rohit commented Apr 25, 2019

access2rohit commented Apr 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

access2rohit Apr 26, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

access2rohit commented May 8, 2019

access2rohit commented Apr 25, 2019 •

edited

Loading

access2rohit Apr 26, 2019 •

edited

Loading