Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false #14466

Merged
merged 8 commits into from
Mar 20, 2019
Merged

[MKL-DNN] Enable s8 support for inner product and 3d input with flatten=false #14466

merged 8 commits into from
Mar 20, 2019

Conversation

xinyu-intel
Copy link
Contributor

Description

Major changes:

  • Integrate mkl-dnn signed int8 inner product;
  • support 3-d input with flatten=false for both f32/int8 inner product.

This PR can also fix issues in #14407

@pengzhao-intel @TaoLv @ciyongch

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pengzhao-intel
Copy link
Contributor

@reminisce @anirudh2290 @ZhennanQin @ciyongch please help take a review :)

ZhennanQin
ZhennanQin approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@ZhennanQin ZhennanQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me except minor coding style issue.

src/operator/quantization/quantized_fully_connected.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_fully_connected.cc Outdated Show resolved Hide resolved
@ciyongch
Copy link
Contributor

LGTM :)

@ciyongch ciyongch mentioned this pull request Mar 19, 2019
Closed
6 tasks
@TaoLv TaoLv added MKLDNN Quantization Issues/Feature Requests related to Quantization labels Mar 19, 2019
pengzhao-intel
pengzhao-intel approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel pengzhao-intel mentioned this pull request Mar 19, 2019
Closed
TaoLv
TaoLv approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments. LGTM now.

@pengzhao-intel
Copy link
Contributor

Looks good and all reviewers approved the PR.

Thanks for your contribution. Merging now :)

@pengzhao-intel pengzhao-intel merged commit f838f67 into apache:master Mar 20, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
@xinyu-intel @vdantu
[MKL-DNN] Enable s8 support for inner product and 3d input with flatt…
512d466 
…en=false (apache#14466)

* support 3d input innerproduct with flatten=false

* simplify test case and improve error msg

* enable s8s8 inner product

* improve code style

* add tests and improve error msg
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
@xinyu-intel @ZhennanQin
[MKL-DNN] Enable s8 support for inner product and 3d input with flatt…
3b5276c 
…en=false (apache#14466)

* support 3d input innerproduct with flatten=false

* simplify test case and improve error msg

* enable s8s8 inner product

* improve code style

* add tests and improve error msg
nswamy pushed a commit that referenced this pull request Apr 5, 2019
@xinyu-intel @nswamy
[MKL-DNN] Enable s8 support for inner product and 3d input with flatt…
adc0ce7 
…en=false (#14466)

* support 3d input innerproduct with flatten=false

* simplify test case and improve error msg

* enable s8s8 inner product

* improve code style

* add tests and improve error msg
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@xinyu-intel
[MKL-DNN] Enable s8 support for inner product and 3d input with flatt…
008fea2 
…en=false (apache#14466)

* support 3d input innerproduct with flatten=false

* simplify test case and improve error msg

* enable s8s8 inner product

* improve code style

* add tests and improve error msg
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhennanQin ZhennanQin ZhennanQin approved these changes

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@TaoLv TaoLv TaoLv approved these changes

@ciyongch ciyongch ciyongch approved these changes

Assignees
No one assigned
Labels
MKLDNN Quantization Issues/Feature Requests related to Quantization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xinyu-intel @pengzhao-intel @ciyongch @TaoLv @ZhennanQin