This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
MXNet Java bug fixes and experience improvement #14213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushghai
reviewed
Feb 20, 2019
<groupId>org.apache.mxnet</groupId> | ||
<artifactId>mxnet-full_${mxnet.scalaprofile}-${mxnet.profile}</artifactId> | ||
<version>${mxnet.version}</version> | ||
<classifier>sources</classifier> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attaching the sources jar
piyushghai
approved these changes
Feb 20, 2019
zachgk
approved these changes
Feb 21, 2019
aaronmarkham
suggested changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for the Readme.
@aaronmarkham Please review it again |
aaronmarkham
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good.
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* improve Java user experience * add the new examples * fixed based on the comments
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
* improve Java user experience * add the new examples * fixed based on the comments
lanking520
added a commit
to lanking520/incubator-mxnet
that referenced
this pull request
Apr 26, 2019
* improve Java user experience * add the new examples * fixed based on the comments
zachgk
pushed a commit
to zachgk/incubator-mxnet
that referenced
this pull request
May 16, 2019
* improve Java user experience * add the new examples * fixed based on the comments
4 tasks
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* improve Java user experience * add the new examples * fixed based on the comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add visualization method to Java users and source code fetching in demo section
@zachgk @piyushghai @andrewfayres @yzhliu
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.