This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Enhance subgraph API #14113
Merged
Enhance subgraph API #14113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review, Operator] |
ZhennanQin
force-pushed
the
subgraph_v2
branch
from
def7f10 to
d7eb33d
Compare
7 tasks
This was referenced Feb 28, 2019
|
@ZhennanQin could you re-trigger the CI? |
|
@ZhennanQin Could you please re-trigger the CI and see why some of the checks are still waiting? Thanks ! |
|
@anirudh2290 @reminisce please help review the continuous improvements for subgraph after #14277 |
reminisce
reviewed
Mar 28, 2019
src/operator/subgraph/mkldnn/mkldnn_post_quantize_align_scale_property.h
Show resolved
Hide resolved
|
@ZhennanQin @xinyu-intel please resolve the comments and re-trigger the PR. |
pengzhao-intel
approved these changes
Mar 30, 2019
xinyu-intel
approved these changes
Mar 30, 2019
reminisce
approved these changes
Mar 30, 2019
|
Thanks for your contribution. Merging now. |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Enhance subgraph API * Fix lint * Trigger CI * Fix test * split into another PR * Rename partition_graph to build_graph * Fix lint * Fix merge * run CI * run CI * fix quantize script * fix ssd script * Address reminisce comment
ZhennanQin
added a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
* Enhance subgraph API * Fix lint * Trigger CI * Fix test * split into another PR * Rename partition_graph to build_graph * Fix lint * Fix merge * run CI * run CI * fix quantize script * fix ssd script * Address reminisce comment
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Enhance subgraph API * Fix lint * Trigger CI * Fix test * split into another PR * Rename partition_graph to build_graph * Fix lint * Fix merge * run CI * run CI * fix quantize script * fix ssd script * Address reminisce comment
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Enhance subgraph API * Fix lint * Trigger CI * Fix test * split into another PR * Rename partition_graph to build_graph * Fix lint * Fix merge * run CI * run CI * fix quantize script * fix ssd script * Address reminisce comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reminisce @zheng-da @apeforest @szha @pengzhao-intel
PR Major change:
Introduce
SubgraphSelectorV2that acceptsBiDirectedNodeinstead ofnnvm::Nodeto get full context of visited node.BiDirectedNodeis double linked version ofnnvm::Node, which can list the output consumer of node. This is very useful to help make selection which has output requirement. Wrapper classSubgraphSelectorV2Bridgeis added to convertSubgraphSelectortoSubgraphSelectorV2, which allows developer to continue using oldSubgraphSelector. So this feature is fully back-compatible.Introduce
kAdjustmode forSubgraphPropertyto allow adjusting network parameters instead of create new node. New APIAdjustSubgraphNode()is added toSubgraphPropertyfor this, which can adjust selected nodes attributes. This is useful when we don't want to create new subgraph node, but to do some modification on selected nodes. Quantized scale alignment optimization is pending on this feature.Change the behavior of PartitionGraph to create single subgraph node for nodes isolating with each other. https://cwiki.apache.org/confluence/display/MXNET/Enable+Operator+Level+Parallelism+under+Subgraph is depending on this change.
Add new subgraph pass "quantized scale alignment optimization" as an example for new subgraph API.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.