-
Notifications
You must be signed in to change notification settings - Fork 6.8k
ONNX import/export: Add missing tests, ONNX export: LogSoftMax #13654
ONNX import/export: Add missing tests, ONNX export: LogSoftMax #13654
Conversation
@mxnet-label-bot add [ONNX, pr-awaiting-review] |
b01106e
to
94b22ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mxnet-label-bot update [ONNX, pr-awaiting-merge] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please explain why some of the tests have been removed?
@mxnet-label-bot update [ONNX, pr-work-in-progress] |
e155725
to
a1ccc7f
Compare
@mxnet-label-bot update [ONNX, pr-awaiting-review] |
a2072ee
to
8e81c64
Compare
8e81c64
to
9d7181a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks one minor comment.
9d7181a
to
689d57e
Compare
689d57e
to
81fb2f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for fixing other operator error messaging as well!
…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support
…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support
Description
Adding tests for operators that can currently be exported/imported from/to ONNX. Correcting the name of some tests. Added ONNX export of LogSoftMax too.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
ONNX export:
ONNX import:
Comments