-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@zheng-da @anirudh2290 @sandeep-krishnamurthy @yuxihu @frankfliu Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
Codecov Report
@@ Coverage Diff @@
## master #13555 +/- ##
==========================================
+ Coverage 82.69% 83.24% +0.54%
==========================================
Files 720 745 +25
Lines 79320 83337 +4017
Branches 3190 3188 -2
==========================================
+ Hits 65596 69376 +3780
- Misses 12863 13102 +239
+ Partials 861 859 -2
Continue to review full report at Codecov.
|
@mxnet-label-bot Update [pr-awaiting-merge] |
@mxnet-label-bot Update [pr-awaiting-merge, Operator] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
@TaoLv - I see your comments are addressed. This is good to merge, I will wait for your confirmation. |
Can you add the remaining test for |
@anirudh2290 It's planned for a different PR as this PR does not directly fix |
Seems all comments are addressed. Now merging. |
* upstream/master: [MXNET-1253] fix control_flow_op (apache#13555) Add imresize and copyMakeBorder to mx.image (apache#13357)
Description
Support large array in control_flow_ops
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes