This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fixing a 404 in the ubuntu setup doc #13542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine because it is used like this all over, but for future reference I'm pretty sure using .md as the extension is preferred as it will work both for github viewing and for the website. Whereas like this, it only works for the website.
Good to know. Next time I touch the Scala/Java docs I'll try and remember to go through and add .md to the links. |
piyushghai
approved these changes
Dec 5, 2018
zachgk
approved these changes
Dec 5, 2018
lanking520
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TaoLv
added a commit
that referenced
this pull request
Dec 6, 2018
…icense file" (#13558) * Revert "Chi_square_check for discrete distribution fix (#13543)" This reverts commit cf6e8cb. * Revert "Updated docs for randint operator (#13541)" This reverts commit e0ff3c3. * Revert "Simplifications and some fun stuff for the MNIST Gluon tutorial (#13094)" This reverts commit 8bbac82. * Revert "Fix #13521 (#13537)" This reverts commit f6b4665. * Revert "Add a retry to qemu_provision (#13551)" This reverts commit f6f8401. * Revert "[MXNET-769] Use MXNET_HOME in a tempdir in windows to prevent access denied due t… (#13531)" This reverts commit bd8e0f8. * Revert "[MXNET-1249] Fix Object Detector Performance with GPU (#13522)" This reverts commit 1c8972c. * Revert "Fixing a 404 in the ubuntu setup doc (#13542)" This reverts commit cb0db29. * Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file (#13478)" This reverts commit 40db619.
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
zhaoyao73
pushed a commit
to zhaoyao73/incubator-mxnet
that referenced
this pull request
Dec 13, 2018
…icense file" (apache#13558) * Revert "Chi_square_check for discrete distribution fix (apache#13543)" This reverts commit cf6e8cb. * Revert "Updated docs for randint operator (apache#13541)" This reverts commit e0ff3c3. * Revert "Simplifications and some fun stuff for the MNIST Gluon tutorial (apache#13094)" This reverts commit 8bbac82. * Revert "Fix apache#13521 (apache#13537)" This reverts commit f6b4665. * Revert "Add a retry to qemu_provision (apache#13551)" This reverts commit f6f8401. * Revert "[MXNET-769] Use MXNET_HOME in a tempdir in windows to prevent access denied due t… (apache#13531)" This reverts commit bd8e0f8. * Revert "[MXNET-1249] Fix Object Detector Performance with GPU (apache#13522)" This reverts commit 1c8972c. * Revert "Fixing a 404 in the ubuntu setup doc (apache#13542)" This reverts commit cb0db29. * Revert "Bumped minor version from 1.4.0 to 1.5.0 on master, updated License file (apache#13478)" This reverts commit 40db619.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a 404 linking error in the ubuntu setup doc. The url to the java setup page was incorrect.
@lanking520 @piyushghai @zachgk @aaronmarkham
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.