-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-949] Module API to Gluon API tutorial #12542
[MXNET-949] Module API to Gluon API tutorial #12542
Conversation
Thanks for your contribution @ThomasDelteil |
@ThomasDelteil - Can you please rebase and resolve conflict? |
@aaronmarkham for review @sandeep-krishnamurthy Please change the label to pr-awaiting-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enjoyed this tutorial. This comparison was really needed. There are some minor grammatical/spelling issues and some clarity needs. I feel like each section should have a standard flow:
- overall intro of what the section does and very high level of how module/gluon differ
- code examples with intro
- compare / contrast detail + links to more examples
@ThomasDelteil Can you please address review comments and resolve conflicting files? |
ping @ThomasDelteil , any update on this PR? |
@roywei going to go through the comments this afternoon and push an update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a note on how to visualize networks in - symbol graphs vs gluon blocks?
@ThomasDelteil thanks for the contribution - can you please follow up on the comments? |
will re-open once I have time to address the comments, thanks all for the reviews 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much needed tutorial! Great job @ThomasDelteil. Only very minor suggestions.
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
Description
Adding a tutorial to show the correspondence between Module and Gluon API to help users transition from the Module API to the Gluon one.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.