Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debugging output that should not appear in a passing test #135

Merged
merged 1 commit into from
Mar 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public void testPreserveSingleQuotesOnArgument()
List<String> shellCommandLine = sh.getShellCommandLine("\"some arg with spaces\"");

String cli = StringUtils.join( shellCommandLine.iterator(), " " );
System.out.println( cli );
assertTrue( cli.endsWith( "'\"some arg with spaces\"'" ) );
}

Expand All @@ -95,7 +94,6 @@ public void testAddSingleQuotesOnArgumentWithSpaces()
List<String> shellCommandLine = sh.getShellCommandLine("some arg with spaces");

String cli = StringUtils.join( shellCommandLine.iterator(), " " );
System.out.println( cli );
assertTrue( cli.endsWith("'some arg with spaces'"));
}

Expand All @@ -114,8 +112,6 @@ public void testAddArgumentWithSingleQuote()
public void testArgumentsWithSemicolon()
{

System.out.println( "---- semi colon tests ----" );

Shell sh = newShell();

sh.setWorkingDirectory( "/usr/bin" );
Expand All @@ -124,7 +120,6 @@ public void testArgumentsWithSemicolon()
List<String> shellCommandLine = sh.getShellCommandLine(";some&argwithunix$chars");

String cli = StringUtils.join( shellCommandLine.iterator(), " " );
System.out.println( cli );
assertTrue( cli.endsWith( "';some&argwithunix$chars'" ) );

Commandline commandline = new Commandline( newShell() );
Expand All @@ -134,7 +129,6 @@ public void testArgumentsWithSemicolon()
commandline.createArg().setValue( ";password" );

List<String> lines = commandline.getShell().getShellCommandLine( commandline.getArguments() );
System.out.println( lines );

assertEquals( "/bin/sh", lines.get( 0 ) );
assertEquals( "-c", lines.get( 1 ) );
Expand All @@ -146,7 +140,6 @@ public void testArgumentsWithSemicolon()
commandline.createArg().setValue( "--password" );
commandline.createArg().setValue( ";password" );
lines = commandline.getShell().getShellCommandLine( commandline.getArguments() );
System.out.println( lines );

assertEquals( "/bin/sh", lines.get( 0) );
assertEquals( "-c", lines.get( 1 ) );
Expand All @@ -157,7 +150,6 @@ public void testArgumentsWithSemicolon()
commandline.createArg().setValue( "--password" );
commandline.createArg().setValue( ";password" );
lines = commandline.getShell().getShellCommandLine( commandline.getArguments() );
System.out.println( lines );

assertEquals( "cmd.exe", lines.get( 0 ) );
assertEquals( "/X", lines.get( 1 ) );
Expand Down Expand Up @@ -195,7 +187,6 @@ public void testBourneShellQuotingCharacters()
commandline.createArg().setValue( "#" );

List<String> lines = commandline.getShell().getShellCommandLine( commandline.getArguments() );
System.out.println( lines );

assertEquals( "/bin/sh", lines.get( 0 ) );
assertEquals( "-c", lines.get( 1 ) );
Expand Down