KAFKA-18331: Update process.roles to required configuration #18414
+85
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
reviewed
Jan 9, 2025
| @@ -125,7 +124,7 @@ public class KRaftConfigs { | |||
| public static final ConfigDef CONFIG_DEF = new ConfigDef() | |||
| .define(METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES_CONFIG, LONG, METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES, atLeast(1), HIGH, METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES_DOC) | |||
| .define(METADATA_SNAPSHOT_MAX_INTERVAL_MS_CONFIG, LONG, METADATA_SNAPSHOT_MAX_INTERVAL_MS_DEFAULT, atLeast(0), HIGH, METADATA_SNAPSHOT_MAX_INTERVAL_MS_DOC) | |||
| .define(PROCESS_ROLES_CONFIG, LIST, Collections.emptyList(), ConfigDef.ValidList.in("broker", "controller"), HIGH, PROCESS_ROLES_DOC) | |||
| .define(PROCESS_ROLES_CONFIG, LIST, List.of("broker"), ConfigDef.ValidList.in("broker", "controller"), HIGH, PROCESS_ROLES_DOC) | |||
There was a problem hiding this comment.
Would it make sense to make the config mandatory instead of having a default?
There was a problem hiding this comment.
yes, this configuration should be mandatory.
There was a problem hiding this comment.
Let's make sure the error message is also good when the config isn't provided.
There was a problem hiding this comment.
And we should have this set in the default server.properties we ship with.
There was a problem hiding this comment.
Thanks for review. I update the validation for process.roles. It's required configuration now.
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-18331
branch
from
73a4e7f to
14099a2
Compare
FrankYang0529
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.0, there is no ZK mode. We should update
process.rolesas required configuration.Committer Checklist (excluded from commit message)