Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28700: MRCompactor may cause data loss when performing the major… #5603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dengzhhu653
Copy link
Member

… compaction

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

}
if (baseAttemptId != null) {
deltasToAttemptId.put(base.getName(), baseAttemptId);
Copy link
Member

@deniskuzZ deniskuzZ Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we use full path in OrcRawRecordMerger to fetch the attemptId?

if (deltasToAttemptId != null) {
  attemptId = deltasToAttemptId.get(mergerOptions.getBaseDir().toString());
}

all TestCompactor tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants