HIVE-28635: Fix logging format issues in ContainerRunnerImpl file #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maheshrajus
force-pushed
the
HIVE-28635
branch
from
a70d995 to
6f3d36b
Compare
asf-ci-hive
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
kokila-19
reviewed
Jan 8, 2025
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Outdated
Show resolved
Hide resolved
kokila-19
reviewed
Jan 8, 2025
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Outdated
Show resolved
Hide resolved
kokila-19
reviewed
Jan 8, 2025
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Outdated
Show resolved
Hide resolved
maheshrajus
force-pushed
the
HIVE-28635
branch
from
6f3d36b to
9ef0ab3
Compare
abstractdog
reviewed
Jan 8, 2025
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Outdated
Show resolved
Hide resolved
abstractdog
reviewed
Jan 8, 2025
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
Outdated
Show resolved
Hide resolved
maheshrajus
force-pushed
the
HIVE-28635
branch
from
9ef0ab3 to
aecacac
Compare
kokila-19
approved these changes
Jan 8, 2025
|
LGTM +1 |
asf-ci-hive
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix logging format issues in ContainerRunnerImpl file
Why are the changes needed?
should use logging format instead of string concatenation
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Existing UT