HIVE-28657: Use protoc-jar-maven-plugin to generate protobuf classes #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Can you add a description of what command to use to compile&generate protobuf codes? |
@zhangbutao , thanks for the review. There is not explicit command used, the use of this plugin is to generate the protobuf code on the fly and remove the protobuf profile. Please see the description of this JIRA HIVE-28657 and TEZ-4428. |
|
+1 LGTM |
|
@abstractdog, can you please help with the review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-28657
Why are the changes needed?
Currently we need to maintain the generated protobuf java code whenever we update protobuf version by running
-Pprotobufprofile. We can use protoc-jar-maven-plugin to dynamically generate protobuf classes from proto files.Does this PR introduce any user-facing change?
NO
Is the change a dependency upgrade?
NO
How was this patch tested?
Will check the CI result