HIVE-28486: Upgrade commons-collections to commons-collections4 due t… #5588
Conversation
|
@eshwitha , I have tried to migrate from commons-collection 3.x to 4.x in past but complete migration is not achievable. IIRC, there are 2 reasons:
with your PR also, in packaging lib dir both the version of commons-collections i.e. 3.x and 4.x are present. |
| @@ -18,7 +18,7 @@ | |||
| package org.apache.hadoop.hive.metastore.txn; | |||
|
|
|||
| import com.google.common.annotations.VisibleForTesting; | |||
| import org.apache.commons.collections.CollectionUtils; | |||
| import org.apache.commons.collections4.CollectionUtils; | |||
There was a problem hiding this comment.
Just thinking out loud, I don't see any commons-collections-3.x dependency present in standalone-metastore module, so commons-collections-3.x must be coming from some transitive dependency (either from hadoop/atlas/commons-beanutils), now in this PR we will start shipping commons-collections-4.x in standalone-metastore/metastore-server/target/apache-hive-metastore-4.1.0-SNAPSHOT-bin. Can it cause any classpath issue?
eshwitha
force-pushed
the
commons-collections4
branch
from
e75b245 to
aa9c67c
Compare
|
…o EOL.
What changes were proposed in this pull request?
Upgrade commons-collections:commons-collections to org.apache.commons:commons-collections4 as it has reached EOL.
Why are the changes needed?
https://mvnrepository.com/artifact/commons-collections/commons-collections is an EOL library and needs to be migrated to commons-collections4.
Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?