Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize some configuration information of HTTP Sink Connector #4873

Closed
3 tasks done
cnzakii opened this issue May 9, 2024 · 1 comment · Fixed by #4874
Closed
3 tasks done

[Enhancement] Optimize some configuration information of HTTP Sink Connector #4873

cnzakii opened this issue May 9, 2024 · 1 comment · Fixed by #4874
Labels
enhancement New feature or request

Comments

@cnzakii
Copy link
Contributor

cnzakii commented May 9, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Optimize some configuration information of HTTP Sink Connector

Describe the solution you'd like

  1. Remove the ssl field from the config file, this field is not valid
    2024-05-10_00 36 59
  2. Change the default value of maxRetries to 2 (first attempts are not counted), 3 attempts is the common practice.
    2024-05-10_00 37 56

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@cnzakii cnzakii added the enhancement New feature or request label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Welcome to the Apache EventMesh community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Assistant WeChat Public Account Slack
Join Slack Chat

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives
Issues Issues or PRs comments and reviews Subscribe Unsubscribe Mail Archives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant