Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize the message body of the Rust SDK's returned reply message #4633

Closed
3 tasks done
mxsm opened this issue Dec 8, 2023 · 2 comments · Fixed by #4751
Closed
3 tasks done

[Enhancement] Optimize the message body of the Rust SDK's returned reply message #4633

mxsm opened this issue Dec 8, 2023 · 2 comments · Fixed by #4751
Assignees
Labels
enhancement New feature or request

Comments

@mxsm
Copy link
Member

mxsm commented Dec 8, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Optimize the message body of the Rust SDK's returned reply message.
link #4631

Describe the solution you'd like

Optimize the message body of the Rust SDK's returned reply message

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@mxsm mxsm added the enhancement New feature or request label Dec 8, 2023
@kyooosukedn
Copy link
Contributor

Hi, I am willing to work on this issue, can u please provide more details? I looked into request_reply_inner method inside grpc_client.rs and AFAIK what i need to do is

  1. Check if it's a subscription reply message
  2. Do additional logging for subscription reply
  3. Add attributes to indicate subscription response

@mxsm
Copy link
Member Author

mxsm commented Jan 16, 2024

Hi, I am willing to work on this issue, can u please provide more details? I looked into request_reply_inner method inside grpc_client.rs and AFAIK what i need to do is

  1. Check if it's a subscription reply message
  2. Do additional logging for subscription reply
  3. Add attributes to indicate subscription response

@kyooosukedn Sure.
Delete the SubscriptionReply struct, which has already been deleted in the Java SDK. For more details, please refer to PR#4632. For the specific implementation logic, please refer to the Java SDK SubStreamHandler#createReceiver method.
The implementation in the Rust SDK is in the subscribe method in grpc_consumer.rs. Here you can find that only EventMeshMessage is supported, and other modifications will be made later. Therefore, you can simply follow the existing logic.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants