findbugs: repeated condition seems c&p error #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tested states sugest that EXPUNGED should be the last one
|
@DaanHoogland you're right, we should not be trying to delete a volume that is already destroyed, expunged or is being expunged. LGTM, merging now. |
asfgit
pushed a commit
that referenced
this pull request
Jun 19, 2015
… that EXPUNGED should be the last one Signed-off-by: Rohit Yadav <[email protected]> This closes #491 (cherry picked from commit bb613ba) Signed-off-by: Rohit Yadav <[email protected]>
|
cloudstack-pull-requests #506 FAILURE |
kishankavala
pushed a commit
to kishankavala/cloudstack
that referenced
this pull request
Jun 25, 2015
… that EXPUNGED should be the last one Signed-off-by: Rohit Yadav <[email protected]> This closes apache#491
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #490 Fixes #491 Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tested states sugest that EXPUNGED should be the last one. Might be that it can be removed altogether instead.
@mike-tutkowski @bhaisaab @sanjaytripathi and maybe others; you know better then me!