Fix crash of COPY FROM on AO/AOCO/PAX partition tables. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
approved these changes
Aug 1, 2024
gfphoenix78
reviewed
Aug 6, 2024
|
table_finish_bulk_insert is still needed in many places to clean up resource, GPDB use aoco_dml_init() to init resource and table_finish_bulk_insert() to clean up, ex: create as. Move fix to copyFrom to work around. |
|
Make a new approach to fix, @my-ship-it @gfphoenix78 , PTAL. |
my-ship-it
reviewed
Aug 8, 2024
AO/AOCO/PAX tables clean up state in am routine finish_bulk_insert() which may be called multiple times during COPY FROM. For a partitioned table has more than 32 partitions(MAX_PARTITION_BUFFERS), when copy partition buffer is flushed, some partitions would be cleaned up with table_finish_bulk_insert(). And if the next input tuple belongs to that partition we just flushed out on the same segment, crash will happen. Authored-by: Zhang Mingli [email protected]
avamingli
changed the title
my-ship-it
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #547
AO/AOCO tables clean up state in am routine finish_bulk_insert() which may be called multiple times during COPY FROM
For a partitioned table has more than 32 partitions(MAX_PARTITION_BUFFERS), when copy partition buffer is flushed(enough tuples or bytes in buffer), some partitions would be cleaned up with table_finish_bulk_insert().
And if the next input tuple belongs to that partition we just flushed out on the same segment, crash will happen.
COPY partitioned table FROM xxx..
T0: QD route data to segments and partitions, buffer with 32 partitions on segment0 is not full.
T1: buffer on segment0 with 33 partition is full, it's flushed and swap out p1 table(finish_bulk_insert called, p1 insert state is released).
T2: QD route new data belongs to partition1(p1) on segment0, then crash happened.
Authored-by: Zhang Mingli [email protected]
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳