Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class names to access static variables or methods #2829

Closed
wants to merge 2 commits into from
Closed

Use class names to access static variables or methods #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f123d0
Accessing the static variables and methods of the class through the o…
lordcheng10 Oct 14, 2021
6459b2a
Merge branch 'master' into class_name_access_static_method
lordcheng10 Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata-drivers/etcd/src/main/java/org/apache/bookkeeper/metadata/etcd/EtcdWatchClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ private void processError(Throwable t) {
}

Status status = Status.fromThrowable(t);
if (this.isHaltError(status) || this.isNoLeaderError(status)) {
if (EtcdWatchClient.isHaltError(status) || EtcdWatchClient.isNoLeaderError(status)) {
this.notifyWatchers(toEtcdException(status));
this.closeGrpcWatchStreamObserver();
this.cancelSet.clear();
Expand Down Expand Up @@ -291,7 +291,7 @@ private void processCreate(WatchResponse response) {
private Optional<WatchRequest> nextResume() {
EtcdWatcher pendingWatcher = this.pendingWatchers.peek();
if (pendingWatcher != null) {
return Optional.of(this.toWatchCreateRequest(pendingWatcher));
return Optional.of(EtcdWatchClient.toWatchCreateRequest(pendingWatcher));
}
return Optional.empty();
}
Expand Down
2 changes: 1 addition & 1 deletion stream/distributedlog/core/src/main/java/org/apache/distributedlog/lock/ZKSessionLock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ private void claimOwnership(int lockEpoch) {
private void unlockInternal(final CompletableFuture<Void> promise) {

// already closed or expired, nothing to cleanup
this.epochUpdater.incrementAndGet(this);
ZKSessionLock.epochUpdater.incrementAndGet(this);
if (null != watcher) {
this.zkClient.unregister(watcher);
}
Expand Down