Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2825: Fix gradle.dependencies related to PR 2792 #2826

Conversation

RaulGracia
Copy link
Contributor

Motivation

Fixes gradle build from breaking changes in PR #2792 by strictly matching both gradle and maven dependencies.

Changes

Revert log4j and bouncycastle dependencies to their original version, to strictly match what we is defined in pom.xml.
Upgraded slf4j to match what is defined in pom.xml.

How to verify it

Run gradlew build has been also manually on a local VM:

/gradlew bookkeeper-server:test --tests="org.apache.bookkeeper.client.*" -Dtestlogger.theme=plain
...
<============-> 98% EXECUTING [15m 52s]
> :bookkeeper-server:test > 252 tests completed, 1 skipped

Master Issue: #2825

… same as in pom.xml. Make Slf4j dependency to be same as in pom.xml.

Signed-off-by: Raúl <[email protected]>
@RaulGracia
Copy link
Contributor Author

RaulGracia commented Oct 14, 2021

@pkumar-singh @eolivelli please, could you check via gradlew that this also works in your setting? I want to be sure that everything is green before going any step further.

@eolivelli
Copy link
Contributor

checking locally now

@RaulGracia RaulGracia marked this pull request as ready for review October 14, 2021 13:22
@pkumar-singh
Copy link
Member

pkumar-singh commented Oct 14, 2021

@RaulGracia Trust pipeline to test. Actually If you see, jobs moved to gradle are stable enough. That are Bookie tests and client tests. Most of important aspect of gradle migration as I am doing it is.

  1. No change should be breaking.
  2. Should do what maven does and does correctly, but does in isolation not affecting maven.
  3. Do not modify any source code/test code.
  4. Gradle should pull exact same dependencies as gradle does right or wrong.That means more important to be consistent with maven than be right.
  5. It means If tests are failing then either tests are flaking or PR has issues.

@RaulGracia
Copy link
Contributor Author

Superseded by #2816.

@RaulGracia RaulGracia closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants