Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Bookkeeper with gradle on Java11 #2814

Closed

Conversation

pradeepbn
Copy link
Contributor

@pradeepbn pradeepbn commented Oct 6, 2021

Descriptions of the changes in this PR:

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)

Master Issue: #


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

Prashant Kumar and others added 5 commits September 30, 2021 13:18
@@ -34,8 +34,8 @@ task generateJniHeaders(type:Exec) {
}
dependsOn classes
def classpath = sourceSets.main.output.classesDirs.join(":")
commandLine("javah", "-d", javahOutputDir, "-classpath",
classpath, "com.scurrilous.circe.crc.Sse42Crc32C")
commandLine("javac", "-h", javahOutputDir, "-classpath",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, gradle has first class support for JNI headers now. i didn't check the version, and i don't know gradle well enough yet to update the dependencies for the shared objects.

https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.CompileOptions.html#org.gradle.api.tasks.compile.CompileOptions:headerOutputDirectory

Copy link
Contributor Author

@pradeepbn pradeepbn Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, totally agree @mauricebarnum and made relevant changes in another PR #2817. I will close this PR since this is based on @pkumar-singh PR #2812 and want to keep it independent of #2812 changes.

@pradeepbn pradeepbn closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants