Add metrics and internal command for AutoRecovery #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankxieke
force-pushed
the
auto_recovery_metrics_and_command
branch
2 times, most recently
from
503a9ee to
e912546
Compare
hangc0276
reviewed
Aug 20, 2021
...va/org/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommand.java
Outdated
Show resolved
Hide resolved
...va/org/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommand.java
Outdated
Show resolved
Hide resolved
...rg/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommandTest.java
Outdated
Show resolved
Hide resolved
...rg/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommandTest.java
Outdated
Show resolved
Hide resolved
...rg/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommandTest.java
Outdated
Show resolved
Hide resolved
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
Outdated
Show resolved
Hide resolved
frankxieke
force-pushed
the
auto_recovery_metrics_and_command
branch
2 times, most recently
from
be0d79b to
170bbee
Compare
frankxieke
force-pushed
the
auto_recovery_metrics_and_command
branch
7 times, most recently
from
f127503 to
c10a340
Compare
|
rerun failure checks |
1 similar comment
|
rerun failure checks |
eolivelli
reviewed
Aug 27, 2021
...va/org/apache/bookkeeper/tools/cli/commands/autorecovery/QueryAutoRecoveryStatusCommand.java
Outdated
Show resolved
Hide resolved
…ng underReplicatedSize metrics,read/write latency, internal command for querying recovering ledgersInfo
frankxieke
force-pushed
the
auto_recovery_metrics_and_command
branch
from
c10a340 to
f741b64
Compare
|
rerun failure checks |
3 similar comments
|
rerun failure checks |
|
rerun failure checks |
|
rerun failure checks |
|
@eolivelli Hi, Could you have a look at this PR. Thanks |
hangc0276
approved these changes
Sep 1, 2021
zymap
pushed a commit
that referenced
this pull request
Oct 26, 2021
…ng underReplicatedSize metrics,read/write latency, internal command for querying recovering ledgersInfo (#2768) Motivation: Current AutoRecovery does not have enough metrics or stat command that would help to monitor and debug. So we need to add metrics and admin stat interface to monitor the process of AutoRecovery. For example, current recovering ledgerInfo and under replicated size, read/write latency in recovering. Changes: And QueryAutoRecoveryStatus command and under replicated size metric , read/write latency metric in recovering Documentation: Need doc. (cherry picked from commit 97818f5)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…ng underReplicatedSize metrics,read/write latency, internal command for querying recovering ledgersInfo (apache#2768) Motivation: Current AutoRecovery does not have enough metrics or stat command that would help to monitor and debug. So we need to add metrics and admin stat interface to monitor the process of AutoRecovery. For example, current recovering ledgerInfo and under replicated size, read/write latency in recovering. Changes: And QueryAutoRecoveryStatus command and under replicated size metric , read/write latency metric in recovering Documentation: Need doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current AutoRecovery does not have enough metrics or stat command that would help to monitor and debug. So we need to add metrics and admin stat interface to monitor the process of AutoRecovery. For example, current recovering ledgerInfo and under replicated size, read/write latency in recovering.
Changes:
And QueryAutoRecoveryStatus command and under replicated size metric , read/write latency metric in recovering
Documentation:
Need doc.