-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockstore: Make WriteBatch operations go through LedgerColumn #3687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left 1 nit.
Curious if you were able to observe any speedup in profiling or anything after these changes
I wouldn't expect any speed up from this one; this PR is still mostly just shuffling things around as prep for #3603. 3603 is the one that actually swaps from heap to stack. |
Problem
Vec
's; these allocations occur very frequentlyLedgerColumn
since each column has a fixed-and-known-at-compile-time key lengthLedgerColumn
Summary of Changes
Shift the logic of converting keys from the
Index
type to bytes fromWriteBatch
toLedgerColumn
, and add methods toLedgerColumn
to add puts and deletes into aWriteBatch
This is similar to #3650, with the goal of making #3603 (which will contain the more interesting changes) a smaller diff