[Associated vote ended on 2022-10-11] Unmaintained collection: mellanox.onyx

[mariolenz]

Summary

The mellanox.onyx collection looks unmaintained / abandoned, it has:

• had only few commits the past 6 months about trivial stuff
• all by @Andersson007 to fix tests
• no release on Galaxy since version 1.0.0 2 years ago
• no CI run for 4 months
• no reaction on Unmaintained collection: Removal from Ansible (communtiy) package ansible-collections/mellanox.onyx#25

[Andersson007]

let's proceed

[gundalow]

@samerd Looks like the mellanox.onyx collection is going to be removed from the ansible package. See discussion in #136

Vote is happening in #144

[mariolenz]

I counted votes: 9 x +1 from SC (mariolenz Andersson007 felixfontein briantist russoz markuman gotmax23 gundalow), 2 x + 1 from community (cybette thedoubl3j)

[Andersson007]

I can confirm the count made #136 (comment):
9 x +1 from SC (mariolenz Andersson007 felixfontein briantist russoz markuman gotmax23 gundalow), 2 x + 1 from community (cybette thedoubl3j)

[mariolenz]

In that case the proposal has been accepted and we will announce to remove the collection from Ansible 8.

Thanks all!

[mariolenz]

@gundalow suggested:

• README.md updated to clearly state (at the top) that this is maintained
• A release pushed to Galaxy based off the last release with just the updated README.md (no other CI, etc fixes)
• Any open issues in the repo get a notice saying that the collection is unmaintained and will be removed

This should likely be added to our procedures for removing collections that we have write to

Although I guess the first point should read "is UNmaintained".

But since the collection is unmaintained, I can't update the README.md because the CI fails: ansible-collections/mellanox.onyx#28 😢

[gotmax23]

But since the collection is unmaintained, I can't update the README.md because the CI fails: ansible-collections/mellanox.onyx#28 cry

The repository prevents merging pull requests if CI fails?

[mariolenz]

But since the collection is unmaintained, I can't update the README.md because the CI fails: ansible-collections/mellanox.onyx#28 cry

The repository prevents merging pull requests if CI fails?

Well, yes... that's the idea, isn't it? You don't want to have code that fails the CI. While sometimes the tests are wrong, in most cases the code is buggy. You don't want to merge buggy code, do you?

[gundalow]

I can force merge the PR even if CI fails

[gundalow]

I've merged ansible-collections/mellanox.onyx#28

[gotmax23]

But since the collection is unmaintained, I can't update the README.md because the CI fails: ansible-collections/mellanox.onyx#28 cry

The repository prevents merging pull requests if CI fails?

Well, yes... that's the idea, isn't it? You don't want to have code that fails the CI. While sometimes the tests are wrong, in most cases the code is buggy. You don't want to merge buggy code, do you?

Yes, I agree that's a good practice that we should follow. I was just clarifying.

[mariolenz]

• Any open issues in the repo get a notice saying that the collection is unmaintained and will be removed

I've added this comment to all open issues / PRs of the collection:

This collection is currently unmaintained, so nobody will work on your PR. See #136 for more information.

If you're interested in mainting this collection yourself, please read the maintainer guidelines and let us know if you want to take over on Matrix: #community:ansible.com or on irc.libera.chat: #ansible-community.

[gotmax23]

Implemented in ansible-community/ansible-build-data@27aa007

[suhl79]

I'm not sure if this is the right place to ask this question, but does anybody have any information if NVIDIA is planning to work and release their own version of the ansible module for ONYX switches as they purchased Mellanox?

[Andersson007]

@suhl79 hello, i would suggest contacting the vendor directly, i don't think anyone here knows the answer.