build: add tls for mongo in deployment #754
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneojgurhem
requested review from
ngruelaneo,
lemaitre-aneo and
qdelamea-aneo
|
|
fix: implem fixed callback & terraform
Nico-dl05
force-pushed
the
jg/tls
branch
3 times, most recently
from
49b35f5 to
55fe2d3
Compare
Nico-dl05
force-pushed
the
jg/tls
branch
3 times, most recently
from
1e657f8 to
75b9bee
Compare
Comment on lines
184
to
190
| if (!File.Exists(mongoOptions.CAFile)) | ||
| { | ||
| logger.LogError("CA certificate Mongo file not found at {path}", | ||
| mongoOptions.CAFile); | ||
| throw new FileNotFoundException("CA certificate Mongo file not found", | ||
| mongoOptions.CAFile); | ||
| } |
There was a problem hiding this comment.
This test should be part of the CreateCallback method.
|
|
||
| settings.SslSettings = new SslSettings | ||
| { | ||
| ClientCertificates = new X509Certificate2Collection(authority), |
There was a problem hiding this comment.
This is used for mTLS, but we do not support mTLS for now. It should most likely be unset.
| return isTrusted; | ||
| } | ||
|
|
||
| public static class CertificateValidatorFactory |
There was a problem hiding this comment.
You don't need to have a nested class for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.