Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal bug in connected-accounts-form.blade.php #128

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

VincentLahaye
Copy link
Contributor

Not a big deal, but the modal would break and mess the display.

Not a big deal, but the modal would break and mess the display.
@andrewdwallo
Copy link
Owner

andrewdwallo commented Mar 8, 2024

@VincentLahaye Are you using UUIDs for primary keys instead of auto-incrementing integers? Just curious. I don't have any issues with the modal currently but I am using auto-incrementing integers. Regardless, the PR was merged so I appreciate it.

@andrewdwallo andrewdwallo merged commit 6baede5 into andrewdwallo:3.x Mar 8, 2024
@VincentLahaye
Copy link
Contributor Author

You're welcome.
Yes you're right, I'm using ULID. It was working fine with regular integer ids.
Spotted 2 or 3 other files to update in order to make it work with UUID/ULID. I'll PR asap for that.

@andrewdwallo
Copy link
Owner

Okay sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants