chore: short-lived grype-db cache #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
kzantow
force-pushed
the
feat/cache-grype-db
branch
from
e20e6c2 to
a944310
Compare
kzantow
commented
Jul 29, 2024
| } | ||
|
|
||
| // Add tool to path for this and future actions to use | ||
| core.addPath(grypePath); |
There was a problem hiding this comment.
I think this is not technically a breaking change, since we did not advertise putting grype on the path, but I suspect it will break a number of users of the action who are expecting this behavior: particularly users of the download-action, and if we remove this we should probably publish a new major version.
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
This was referenced Aug 16, 2024
|
An update: we have deployed an updated CDN solution which we believe should have fixed database download issues. Please read more about it on Discourse |
|
@kzantow do you think it would make sense to do this change even after we made the CDN faster? |
wagoodman
reviewed
Oct 4, 2024
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a short-lived cache of the grype database using the Github workflow cache.
If there are a substantial number of users of the action, this may help to spread out checks for grype-db over the day, and alleviate the overall number of requests, to help alleviate the sporadic issues we have seen lately with the CDN.
NOTE: Grype has another change which will result in some type of update interval check, this PR could/should leverage instead of having multiple ways to specify the update interval: anchore/grype#2005
Example runs (with cache in this repo):