✨ Enable native Custom Elements v1 #25173
Conversation
This will attempt to use native CEv1 when supported. Based on whether
the anonymous class remains a real, native ES6 class, we can use 0
polyfill (fully native support). If it's transpiled into a `function ()
{}`, then we can use a minimal polyfill that wraps the `HTMLElement`
constructor only.
jridgewell
force-pushed
the
custom-elements-v1-native
branch
from
e24c911 to
0e9cf82
Compare
| @@ -377,6 +377,8 @@ describe('amp-img', () => { | |||
| it('should propagate the object-fit attribute', () => { | |||
| return getImg({ | |||
| src: '/examples/img/sample.jpg', | |||
There was a problem hiding this comment.
Were these test breaking due to this change (if so why?)?
There was a problem hiding this comment.
I think the native Custom Elements implementations are able to fire connectedCallback much quicker than the MutationObserver the polyfill uses.
|
I created a new RTV experiment so that this can be tested on a smaller population. /cc @lannka and @zhouyx, I also updated the |
Sounds like a great idea! |
There was a problem hiding this comment.
It'd be really convenient if we could change to a
.eslintrc.jsfile, so that we could dynamically generate the defined experiment globals fromexperiments-config.json. @rsimha?
This might be possible, but will require lots of testing with our existing lint toolchain, VS Code, Prettier, etc. Can you file a FR?
* Try enabling native Custom Elements v1
This will attempt to use native CEv1 when supported. Based on whether
the anonymous class remains a real, native ES6 class, we can use 0
polyfill (fully native support). If it's transpiled into a `function ()
{}`, then we can use a minimal polyfill that wraps the `HTMLElement`
constructor only.
* Fix img tests
* Bump travis
* Define NATIVE_CUSTOM_ELEMENTS_V1 RTV Experiemnt
This will attempt to use native CEv1 when supported.
Based on whether the anonymous class remains a real, native ES6 class, we can use 0 polyfill (fully native support). If it's transpiled into a
function () {}, then we can use a minimal polyfill that wraps theHTMLElementconstructor only.