📖 Move extension markdown template into its own file #25164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrystalOnScript
approved these changes
Oct 21, 2019
alanorozco
requested review from
rsimha and
CrystalOnScript
and removed request for
rcebulko
rsimha
approved these changes
Oct 21, 2019
CrystalOnScript
approved these changes
Oct 21, 2019
rsimha
reviewed
Oct 21, 2019
rcebulko
reviewed
Oct 22, 2019
rsimha
suggested changes
Oct 23, 2019
|
Another request: The changes to the link checker are mostly unrelated to the original purpose of this PR. Can you separate those changes into a separate PR? (Doing so after addressing my comments is fine.) |
rsimha
approved these changes
Oct 23, 2019
alanorozco
added a commit
that referenced
this pull request
Oct 23, 2019
Also some modernizing and cleanup. (Offshoot of #25164)
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…#25226) Also some modernizing and cleanup. (Offshoot of ampproject#25164)
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
Keeps `${name}` and `${year}` as interpolation tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps
${name}and${year}as interpolation tokens.