[exporter/awsemf] Renaming APM/Pulse to AppSignals #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
previously approved these changes
Oct 20, 2023
mxiamxia
approved these changes
Oct 23, 2023
lisguo
reviewed
Oct 24, 2023
| pulseMetricNamespace = "AWS/APM" | ||
| pulseLogGroupNamePrefix = "/aws/apm/" | ||
| // AppSignals EMF config | ||
| appSignalsMetricNamespace = "AppSignals" |
There was a problem hiding this comment.
Are we omitting the AWS/ prefix? I think we should still do this as it is reserved
There was a problem hiding this comment.
Spoke offline, this follows same pattern as container insights
lisguo
approved these changes
Oct 24, 2023
lisguo
merged commit dc59406
into
amazon-contributing:aws-cwa-dev
80 of 87 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: It is only for public preview and DO NOT merge it for private beta build.
Description:
Remove all usages of APM/Pulse in EMF exporter and use AppSignals instead.
Testing:
Passed unit test.