Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allure.NUnit 2.9.2-preview.1 logs start and result of each step to console #312

Closed
1 task done
andrematosfundao opened this issue Dec 20, 2022 · 5 comments
Closed
1 task done

Comments

@andrematosfundao
Copy link

andrematosfundao commented Dec 20, 2022

I'm submitting a ...

  • bug report

What is the current behavior?

This library is outputting to console each start of a step, the step name and the result of each step.

image

seems to me some leftover debug logging.
this issue create lots of console logs for tests with many steps and make it difficult to find other relevant information that may have been ouputed to the console.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

any test with a step can generate this on the version Allure.NUnit 2.9.2-preview.1.

 [AllureStep("isLogedinValidationStep")]
    private void isLoggedin()
    {
    }
    [AllureStep("LoginSubStep")]
    private void sublogin()
    {
    }
    [AllureStep("LoginStep")]
    private void login()
    {
        sublogin();
    }

    [Test]
    [AllureName("test1")]
    public void Test1()
    {
        login();
        isLoggedin();
    }

What is the expected behavior?

I believe that the allure library should output nothing to the console by default.

What is the motivation / use case for changing the behavior?

cleaner console output

Please tell us about your environment:

Other information

seems to me that the console logs are generated here:

Log($"Started Step: {name}");

Log("Passed");

@undron
Copy link
Contributor

undron commented Dec 22, 2022

Hi, I've made PR to remove this calls with ability to add own logger to steps.
As for me, it is useful to have steps in text logs

@neparij
Copy link
Contributor

neparij commented Dec 22, 2022

@undron Andrey, thanks for PR!

@andrematosfundao
Copy link
Author

@undron Nice work.

neparij pushed a commit that referenced this issue Dec 23, 2022
@neparij
Copy link
Contributor

neparij commented Dec 23, 2022

Hello everyone!
You can try it out in 2.9.3-preview.1 release

@andrematosfundao
Copy link
Author

can confirm it works fine now on 2.10

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants