-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve the performance of jedis batch commands. #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areyouok
requested changes
Mar 28, 2024
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
redis cluster是不是不能很好的支持mget/mset? |
这个不清楚,但是 JedisCluster 这个对象看起来是没有直接支持类似于 scan 那样多线程去拿的代码的,他的 mget 就是创建了一个:CommandObject, 里面有个 CommandArguments 最后在 ClusterCommandExecutor 里面这样执行的: 然后拿连接也是根据命令参数算出来 slot: 我思考的时候又想了下之前看 redis 源码的时候,Key 在不同的 SLOT 的时候,Redis Cluster 自身就会拒绝这个请求的: 我试了一下,JedisCluster 也确实体现了这一点:
|
areyouok
requested changes
Mar 29, 2024
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
areyouok
requested changes
Mar 29, 2024
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
jetcache-support/jetcache-redis/src/main/java/com/alicp/jetcache/redis/RedisCache.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #865 (comment)
抽象了一下 pipeline 获取的接口,方便其他方法使用(getAll, delAll)