Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from webpack to esbuild #84

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Conversation

jedahan
Copy link
Collaborator

@jedahan jedahan commented Sep 4, 2023

This makes saxi buildable on a raspberry pi zero (webpack OOMs even with 1.5Gb of memory).

This also enables live-reload during development.

This should also speed things up, but i haven't benchmarked it

Jonathan Dahan and others added 2 commits September 4, 2023 13:37
This makes saxi buildable on a raspberry pi zero (webpack OOMs even with 1.5Gb of memory).

This also enables live-reload during development.
@jedahan
Copy link
Collaborator Author

jedahan commented Sep 4, 2023

There were some merge conflicts I tried to manually resolve in the package-lock.json, but I didn't test them - best to regenerate after merge.

@alexrudd2
Copy link
Owner

npm run dev
<snip>
npm ERR! Missing script: "serve"
npm ERR!

The line in question is a script in package.json. { "dev": "npm run serve & BUILD_MODE=development npm run build:ui",.

Is this supposed to be npm run build:server or something?

Copy link
Owner

@alexrudd2 alexrudd2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Typescript downgrade shouldn't be necessary if you upgrade typescript-eslint, since it recently added support for 5.2

typescript-eslint/typescript-eslint#7535

@jedahan
Copy link
Collaborator Author

jedahan commented Sep 6, 2023

ahh yeah, I will add the missing serve script and upgrade typescript-eslint

@alexrudd2
Copy link
Owner

As I commented on the other PR, my intention is to merge all these changes into nornagon/saxi in manageable chunks rather than maintain a fork.

That said, works for me so thanks :)

@alexrudd2 alexrudd2 merged commit 3731448 into alexrudd2:main Sep 8, 2023
@alexrudd2
Copy link
Owner

#98 should be included here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants