Skip to content

Commit

Permalink
tsansup: comment bde stuff
Browse files Browse the repository at this point in the history
Signed-off-by: Aleksandr Ivanov <[email protected]>
  • Loading branch information
alexander-e1off committed Jul 25, 2024
1 parent 00b172e commit 7c020d6
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions etc/tsansup.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,15 @@
# There's a lengthy comment in ObjectPool::getObject that explains why this
# isn't a race. I'm not smart enough to figure out if it's right, but I'll
# assume it's right
race:BloombergLP::bdlcc::ObjectPool<*>::getObject
race:BloombergLP::bdlcc::ObjectPool<*>::releaseObject
race:BloombergLP::bdlma::ConcurrentPool::deallocate
race:BloombergLP::bdlma::ConcurrentPool::allocate
race:BloombergLP::bdlma::ConcurrentPool::deleteObject
#race:BloombergLP::bdlcc::ObjectPool<*>::getObject
#race:BloombergLP::bdlcc::ObjectPool<*>::releaseObject
#race:BloombergLP::bdlma::ConcurrentPool::deallocate
#race:BloombergLP::bdlma::ConcurrentPool::allocate
#race:BloombergLP::bdlma::ConcurrentPool::deleteObject

# Similar to above, there is a lengthy comment in bcema_Pool::allocate which
# attempts to explain why there is no race.
race:BloombergLP::bcema_Pool<*>::allocate

# Not sure what the problem is here, but tsan can't show the other stack, so
# there's nothing to look into
#race:__tsan_atomic32_fetch_add
#race:BloombergLP::bcema_Pool<*>::allocate

# Don't warn about using cout from multiple threads
race:std::basic_ostream<char, *>& bsl::operator<< <*>(std::basic_ostream<*>&, bsl::basic_string<*> const&)
Expand All @@ -24,11 +20,15 @@ race:std::basic_ostream<char, *>& bsl::operator<< <*>(std::basic_ostream<*>&, bs
# it makes tsan warn in some cases
race:BloombergLP::ball::LoggerManager::isInitialized()

# Suppress TSan report in a routine used in bmqimp::Brokersession test driver.
# It is a benign race in the test driver, but should be looked into at some
# point.
#race:TestSession::waitForChannelClose
#race:TestSession::arriveAtStepWithCfgs
# Suppress sporadically appearing data race in bmqimp::Brokersession test driver.
# In TestSession::arriveAtStepWithCfgs() there is a call of queue->setOptions() method,
# at nearly same time in other thread bmqimp::BrokerSession::onConfigureQueueResponse() calls
# queue->options().suspendsOnBadHostHealth() method which is detected as data race.
# bmqt::QueueOptions and bmqimp::Queue classes are not thread safe by design,
# and bmqimp::BrokerSession::onConfigureQueueResponse() cllback access them in
# not thread-safe manner, probably also by design, assuming that it will be called again
# if something is changed. Further investigation is required, suppress it for now.
race:BloombergLP::bmqt::QueueOptions::suspendsOnBadHostHealth

# Since we use mqbmock::Dispatcher in unit tests, this method does not get
# enqueued correctly back to cluster-dispatcher thread, causing potential
Expand Down

0 comments on commit 7c020d6

Please sign in to comment.