Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: merge tsconfig.paths.json into tsconfig.json #9

Closed
DoctorDerek opened this issue Jul 26, 2021 · 2 comments
Closed

Suggestion: merge tsconfig.paths.json into tsconfig.json #9

DoctorDerek opened this issue Jul 26, 2021 · 2 comments

Comments

@DoctorDerek
Copy link

Hey, I'm happy to open a PR to do this quick chore.

I'm not sure why https://github.com/alan2207/bulletproof-react/blob/master/tsconfig.paths.json is a separate file.

To me, it's less clear if anything. And the mandatory clutter (config files) we have is plenty already, right?

I'd never expect to find the paths hanging out in a separate file, though I'd surely notice it.

Feel free to close the issue if you don't approve! Have a good one!

@alan2207
Copy link
Owner

Although I agree with you on this 100%, it is unfortunately required by CRA, otherwise, it will override it every time.
There are several issues on github on CRA project about it. Here is one of them: facebook/create-react-app#8909

I also mentioned it briefly here: https://github.com/alan2207/bulletproof-react/blob/master/docs/project-configuration.md

So for now, let's keep it this way, but thanks anyway :)

@DoctorDerek
Copy link
Author

Cool thanks for the note @alan2207 I don't use CRA myself. Cheers!

thanir03 added a commit to thanir03/bulletproof-react that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants