Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls and require 85% test coverage #37

Merged
merged 3 commits into from
Aug 12, 2017
Merged

Conversation

austinbyers
Copy link
Collaborator

@austinbyers austinbyers commented Aug 10, 2017

Add coverage instrumentation. Unit tests can now be run with coverage run manage.py test
We require 85% coverage for all future PRs for now (that number will increase in the future)

Resolves: #3

to: @ryandeivert
cc: @airbnb/binaryalert-maintainers

Copy link
Contributor

@ryandeivert ryandeivert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@austinbyers austinbyers merged commit 7ec445d into master Aug 12, 2017
@austinbyers austinbyers deleted the abb--coverage branch August 12, 2017 03:11
@austinbyers austinbyers modified the milestone: 1.0.0 Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants