Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-203): explain IDENTIFIER behavior #1241

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

noahdietz
Copy link
Collaborator

The actual behavior was unclear, but what is added conveys the behavior we expected before we had this value.

Also add rationale for its creation/use.

@noahdietz noahdietz requested a review from a team as a code owner October 6, 2023 23:38
@noahdietz noahdietz requested review from hrasadi, andrei-scripniciuc and alin04 and removed request for hrasadi October 6, 2023 23:38
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can go in as-is, but I've suggested purely-aesthetic changes.

aip/general/0203.md Show resolved Hide resolved
aip/general/0203.md Outdated Show resolved Hide resolved
@noahdietz noahdietz merged commit 0fee667 into aip-dev:master Oct 11, 2023
2 checks passed
@noahdietz noahdietz deleted the identifier-behavior branch October 11, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants