fix(AIP-156): Do not define Update on singletons with only output only fields. #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukesneeringer
changed the title
lukesneeringer
commented
Jul 26, 2023
andrei-scripniciuc
approved these changes
Jul 26, 2023
|
Could you include the context of this in the PR description as well for posterity? |
toumorokoshi
reviewed
Aug 2, 2023
| @@ -57,12 +59,15 @@ rpc UpdateConfig(UpdateConfigRequest) returns (Config) { | |||
| - Singleton resources **should** define the [`Get`][aip-131] and | |||
| [`Update`][aip-134] methods, and **may** define custom methods as | |||
| appropriate. | |||
| - However, singleton resources **must not** define the [`Update`][aip-134] | |||
There was a problem hiding this comment.
nit: probably should move the update guidance to it's own line (e.g. singleton resources should define update unless all fields are output-only).
Although It seems like we could just refactor this guidance to just pointing to the update method AIP in general.
toumorokoshi
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the AIP meeting today. Should be non-controversial.