Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10304/b6ffb1d1 backport][3.12] Add aiohttp-openmetrics to list of third party aiohttp-related python… #10306

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 7, 2025

This is a backport of PR #10304 as merged into master (b6ffb1d).

… modules

What do these changes do?

Add aiohttp-openmetrics to the list of third party aiohttp-related python modules.

Are there changes in behavior for the user?

N/A

Is it a substantial burden for the maintainers to support this?

No

Related issue number

N/A

Checklist

  • I think the code is well written (N/A)
  • Unit tests for the changes exist (N/A)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt (N/A)
  • Add a new news fragment into the CHANGES/ folder

Copy link

codecov bot commented Jan 7, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3475 1 3474 104
View the top 1 failed tests by shortest run time
tests.test_web_functional test_response_context_manager_error[pyloop]
Stack Traces | 0.041s run time
aiohttp_server = <function aiohttp_server.<locals>.go at 0x107c705e0>

    #x1B[0m#x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mtest_response_context_manager_error#x1B[39;49;00m(aiohttp_server) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        #x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mhandler#x1B[39;49;00m(request):#x1B[90m#x1B[39;49;00m
            #x1B[94mreturn#x1B[39;49;00m web.Response(text=#x1B[33m"#x1B[39;49;00m#x1B[33msome text#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
        app = web.Application()#x1B[90m#x1B[39;49;00m
        app.router.add_route(#x1B[33m"#x1B[39;49;00m#x1B[33mGET#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, handler)#x1B[90m#x1B[39;49;00m
        server = #x1B[94mawait#x1B[39;49;00m aiohttp_server(app)#x1B[90m#x1B[39;49;00m
        session = aiohttp.ClientSession()#x1B[90m#x1B[39;49;00m
        cm = session.get(server.make_url(#x1B[33m"#x1B[39;49;00m#x1B[33m/#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m))#x1B[90m#x1B[39;49;00m
        resp = #x1B[94mawait#x1B[39;49;00m cm#x1B[90m#x1B[39;49;00m
        #x1B[94mwith#x1B[39;49;00m pytest.raises(#x1B[96mRuntimeError#x1B[39;49;00m):#x1B[90m#x1B[39;49;00m
            #x1B[94masync#x1B[39;49;00m #x1B[94mwith#x1B[39;49;00m resp:#x1B[90m#x1B[39;49;00m
                #x1B[94massert#x1B[39;49;00m resp.status == #x1B[94m200#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
                resp.content.set_exception(#x1B[96mRuntimeError#x1B[39;49;00m())#x1B[90m#x1B[39;49;00m
                #x1B[94mawait#x1B[39;49;00m resp.read()#x1B[90m#x1B[39;49;00m
        #x1B[94massert#x1B[39;49;00m resp.closed#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
>       #x1B[94massert#x1B[39;49;00m #x1B[96mlen#x1B[39;49;00m(session._connector._conns) == #x1B[94m1#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       AssertionError: assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE        +  where 0 = len(defaultdict(<class 'collections.deque'>, {}))#x1B[0m
#x1B[1m#x1B[31mE        +    where defaultdict(<class 'collections.deque'>, {}) = <aiohttp.connector.TCPConnector object at 0x10a0ce140>._conns#x1B[0m
#x1B[1m#x1B[31mE        +      where <aiohttp.connector.TCPConnector object at 0x10a0ce140> = <aiohttp.client.ClientSession object at 0x10a0cf370>._connector#x1B[0m

aiohttp_server = <function aiohttp_server.<locals>.go at 0x107c705e0>
app        = <Application 0x10a0cda20>
cm         = <aiohttp.client._BaseRequestContextManager object at 0x10a0cc760>
handler    = <function test_response_context_manager_error.<locals>.handler at 0x108af5bd0>
resp       = <ClientResponse(http://127.0.0.1:50073/) [200 OK]>
<CIMultiDictProxy('Content-Type': 'text/plain; charset=utf-8', 'Content-Length': '9', 'Date': 'Tue, 07 Jan 2025 00:44:04 GMT', 'Server': 'Python/3.10 aiohttp/3.12.0.dev0')>

server     = <aiohttp.test_utils.TestServer object at 0x10a0cf6d0>
session    = <aiohttp.client.ClientSession object at 0x10a0cf370>

#x1B[1m#x1B[31mtests/test_web_functional.py#x1B[0m:1949: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #10306 will not alter performance

Comparing patchback/backports/3.12/b6ffb1d1a3b710c600f06c9d21cf62f75d324767/pr-10304 (5c171b6) with 3.12 (52e4ea6)

Summary

✅ 47 untouched benchmarks

@Dreamsorcerer Dreamsorcerer merged commit c42472f into 3.12 Jan 7, 2025
35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.12/b6ffb1d1a3b710c600f06c9d21cf62f75d324767/pr-10304 branch January 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants