Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation message says "This will be removed in Ember 2.0.0" #453

Open
mcfiredrill opened this issue Jul 19, 2022 · 0 comments
Open

deprecation message says "This will be removed in Ember 2.0.0" #453

mcfiredrill opened this issue Jul 19, 2022 · 0 comments

Comments

@mcfiredrill
Copy link

I noticed this deprecation message says "This will be removed in Ember 2.0.0".
I know it's supposed to mean version 2.0 of ember-metrics, but a bit misleading.
Not sure if this is a bug here or upstream

DEPRECATION: Future versions of the GoogleTagManagerAdapter will no longer prefix top-level dataLayer keys with `event`. If you wish to retain this behaviour you will need to override the adapter and prefix the keys yourself. [deprecation id: ember-metrics.issue-438] This will be removed in Ember 2.0.0.
@tben tben mentioned this issue Oct 25, 2022
Merged
kategengler pushed a commit to emberjs/ember.js that referenced this issue Nov 2, 2022
@tben @kategengler
Include package name in deprecation function
e9305f2 
So this slightly changes the deprecation message to allow for package (namespace) to be included in the error message. This make it so that the message "will be removed in ember (package version)" is replaced with "will be removed in (package name) (package version)".

This was change was proposed because of this usage:
https://github.com/adopted-ember-addons/ember-metrics/blob/f604272de70e44ac731c711cfad5eae8792ee3ca/addon/metrics-adapters/google-tag-manager.js#L50

and this issue:
adopted-ember-addons/ember-metrics#453

(cherry picked from commit 811fd07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcfiredrill