Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use @faker-js/faker instead of faker #791

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

bnoufel
Copy link
Contributor

@bnoufel bnoufel commented Feb 19, 2022

Proposed changes

use @faker-js/faker instead of faker #759

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes ( for unit test see Some test fail #790 )
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@thetutlage
Copy link
Member

Just to make sure. Is @faker-js/faker a drop-in replacement?

@thetutlage thetutlage self-requested a review February 22, 2022 01:58
@thetutlage thetutlage added the Type: Dependencies Update Bump dependencies label Feb 22, 2022
@RomainLanz
Copy link
Member

Just to make sure. Is @faker-js/faker a drop-in replacement?

Yes, it is a direct, stable fork of faker that you can use as a drop-in replacement.

@RomainLanz RomainLanz closed this Feb 22, 2022
@RomainLanz RomainLanz reopened this Feb 22, 2022
@thetutlage thetutlage merged commit 759f2e4 into adonisjs:develop Feb 22, 2022
@thetutlage
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Update Bump dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants