Support HTTP/2 with rustls

[DemiMarie]

This is a feature request to support HTTP/2 with rustls

[AlbanMinassian]

info only : https://docs.rs/tokio-rustls/0.5.0/tokio_rustls

[fafhrd91]

I can not add rustls support at the moment. all packages needs to depend on same ring package

[mssun]

all packages needs to depend on same ring package

What does it mean? I also hope to see rustls support. I understand rustls depends on ring internally.

[fafhrd91]

rustls depends on ring ^0.13.0-alpha
cookie depends on ring 0.12.1

I think it is not possible to compile two different ring dependency

[mssun]

Correct me if I'm wrong. I remember that cargo can compile with two different version crates. But probably have two copies of library code?

Also, the master cookie support ring ^0.13.0-alpha in Jan. https://github.com/alexcrichton/cookie-rs/blob/master/Cargo.toml#L20

[fafhrd91]

cargo can, but ring uses asm which is the problem. I don't think alpha dependency is good idea

[mssun]

I see. Thank you so much!

[DemiMarie]

May I ask why? RustTLS is already used in production.

…

On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***> wrote: cargo can, but ring uses asm which is the problem. I don't think alpha dependency is good idea — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f> .

[fafhrd91]

You can use anything in production. But if library is ready for production why it is not released as stable version.

…

Sent from my iPhone

On Jun 7, 2018, at 12:49 PM, Demi Marie Obenour ***@***.***> wrote: May I ask why? RustTLS is already used in production. On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***> wrote: > cargo can, but ring uses asm which is the problem. I don't think alpha > dependency is good idea > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#36 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[DemiMarie]

Futures is not stable either.

…

On Thu, Jun 7, 2018, 3:51 PM Nikolay Kim ***@***.***> wrote: You can use anything in production. But if library is ready for production why it is not released as stable version. Sent from my iPhone > On Jun 7, 2018, at 12:49 PM, Demi Marie Obenour < ***@***.***> wrote: > > May I ask why? > > RustTLS is already used in production. > > On Thu, Jun 7, 2018, 2:28 PM Nikolay Kim ***@***.***> wrote: > > > cargo can, but ring uses asm which is the problem. I don't think alpha > > dependency is good idea > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > <#36 (comment)>, or mute > > the thread > > < https://github.com/notifications/unsubscribe-auth/AGGWB_sE_qJWemNfMbEXwTg2lUUTAd2wks5t6XDWgaJpZM4RSS1f > > > . > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGWB0spr0maQB0b-71vqSvbOrJTGl1zks5t6YQ9gaJpZM4RSS1f> .

[fafhrd91]

choice is yours.

as a maintainer of the actix project i chose not to integrate with rustls at this stage.

[Tommoa]

One option to solve the issue of differing ring dependencies is to use rustls 0.11 and tokio-rustls 0.4. Both of them use ring 0.12.1.

[hayd]

Multiple ring versions should work together after briansmith/ring#619 is merged.

[ctz]

This should now be unblocked by https://crates.io/crates/rustls/0.13.0 which depends on the latest ring release without the single-version constraint. Please do let me know if I can help 👍

[DoumanAsh]

We do have cookie that uses ring 0.12 also though

Hopefully after 0.13 stable ring we get new version of cookie rwf2/cookie-rs#106

[fafhrd91]

fixed by #427