Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): upgrade to new parser #127

Merged
merged 3 commits into from
Jun 26, 2020
Merged

refactor(*): upgrade to new parser #127

merged 3 commits into from
Jun 26, 2020

Conversation

jolanglinais
Copy link
Member

No Issue

Support the new parser from cicero

Changes

  • Upgrade markdown-transform and cicero

Flags

  • My branch should be up to date, not sure what's happening in package.json

Related Issues

Author Checklist

  • Commits messages follow AP format
  • Merging to master from fork:branchname

@jolanglinais jolanglinais self-assigned this Jun 26, 2020
@jolanglinais
Copy link
Member Author

Original #126

DianaLease
DianaLease approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better!!

DianaLease
DianaLease requested changes Jun 26, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get this error Uncaught (in promise) TypeError: Cannot read property 'children' of undefined

@jolanglinais jolanglinais requested a review from DianaLease June 26, 2020 17:26
jeromesimeon
jeromesimeon approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! If it works, then LGTM.

DianaLease
DianaLease approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again! 🎉

@jolanglinais jolanglinais merged commit 7af54b0 into accordproject:master Jun 26, 2020
@jolanglinais jolanglinais deleted the irmerk/cicero-parser branch June 26, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@jeromesimeon jeromesimeon jeromesimeon approved these changes

Assignees

@jolanglinais jolanglinais

Labels
Package: Contract Editor 💻 Package: Markdown Editor ⌨️ Package: Storybook 📖 Type: Dependencies 🏠 Pull requests that update a dependency file Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolanglinais @jeromesimeon @DianaLease