Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClick of Drop-down style menu dismisses selected text #291

Closed
d-e-v-esh opened this issue Mar 11, 2021 · 0 comments · Fixed by #292
Closed

onClick of Drop-down style menu dismisses selected text #291

d-e-v-esh opened this issue Mar 11, 2021 · 0 comments · Fixed by #292
Assignees
@d-e-v-esh
Labels
Difficulty: Starter Package: Markdown Editor ⌨️ Type: Bug 🐛 Something isn't working

Comments

@d-e-v-esh
Copy link
Contributor

d-e-v-esh commented Mar 11, 2021 •
edited
Loading

Bug Report 🐛

When we have something selected and we want to change the styling, going to the style dropdown menu and clicking on it, deselects the selected text. Even though the menu is such that it would open up on hover, the rest of the buttons in the toolbar do not have this problem and it creates a bad user experience if it is clicked upon.

Expected Behavior

Clicking on the dropdown menu with the selected text should not deselect the selection.

Current Behavior

Clicking on the menu with selected text deselects the text.
D4ZG33Cq4d

Possible Solution

Adding a preventDefault() to the menu would fix this issue.

Steps to Reproduce

  1. Select any text in the text editor.
  2. Go to the dropdown menu with the selected text and click on the menu.
  3. The selected text would be deselected.

Context (Environment)

Desktop

  • OS: [e.g. macOS]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 0.22.15]
d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Mar 11, 2021
@d-e-v-esh
fix(ui-markdown-editor): text deselection - accordproject#291
e03670b 
Signed-off-by: d-e-v-esh <[email protected]>
@d-e-v-esh d-e-v-esh mentioned this issue Mar 11, 2021
Merged
9 tasks
mttrbrts pushed a commit that referenced this issue Mar 12, 2021
@d-e-v-esh
fix(ui-markdown-editor): text deselection - #291 (#292)
79bc7d1 
Signed-off-by: d-e-v-esh <[email protected]>
Cronus1007 added a commit to Cronus1007/web-components that referenced this issue Mar 12, 2021
@Cronus1007
Merge pull request #1 from accordproject/master
4063bde 
fix(ui-markdown-editor): text deselection - accordproject#291 (accordproject#292)
Cronus1007 added a commit to Cronus1007/web-components that referenced this issue Mar 12, 2021
@Cronus1007
Merge pull request #2 from accordproject/master
1c6ee38 
fix(ui-markdown-editor): text deselection - accordproject#291 (accordproject#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-e-v-esh d-e-v-esh

Labels
Difficulty: Starter Package: Markdown Editor ⌨️ Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui-markdown-editor): text deselection - #291 d-e-v-esh/web-components
2 participants
@jolanglinais @d-e-v-esh