Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph styling options obscured by Clause Template #278

Closed
Michael-Grover opened this issue Mar 4, 2021 · 17 comments · Fixed by #304
Closed

Paragraph styling options obscured by Clause Template #278

Michael-Grover opened this issue Mar 4, 2021 · 17 comments · Fixed by #304

Comments

@Michael-Grover
Copy link

Bug Report 🐛

Paragraph styling options are obscured by Clause Template
image

Expected Behavior

the paragraph styling options dropdown should be in front of all content so that users can choose their styling option.

Current Behavior

Possible Solution

Change the Z-index of some elements of the UI

Steps to Reproduce

  1. go to the contract editor in Netlify
  2. Hover over "normal" on the left side of the formatting toolbar
  3. See that the dropdown is covered by the clause template
    image

Context (Environment)

Mac OS, Chrome

@K-Kumar-01
Copy link
Contributor

@Michael-Grover
I would like to work on this issue

@K-Kumar-01
Copy link
Contributor

@Michael-Grover
I am unable to reproduce the issue. I am on Linux and google chrome. It seems to be working fine here.
Screenshot from 2021-03-05 15-46-13

@Michael-Grover
Copy link
Author

Michael-Grover commented Mar 5, 2021

@K-Kumar-01 interesting. I just confirmed and was able to reproduce the bug on my computer (Macbook pro, Big Sur, Chrome)

@irmerk @dselman @jeromesimeon @rkotangoor anyone able to reproduce this?

@d-e-v-esh
Copy link
Contributor

@Michael-Grover I am able to reproduce this bug. Should I look into it?
crop prob

@K-Kumar-01
Copy link
Contributor

@d-e-v-esh
Could you please tell the system and platform you ate working on?

@d-e-v-esh
Copy link
Contributor

d-e-v-esh commented Mar 7, 2021

@K-Kumar-01 Actually now when I look at it. I can't reproduce it locally either. It only occurs in the Storybook demo online.
chrome_YN51iFBVaM

@Michael-Grover
Copy link
Author

@d-e-v-esh thanks, I've assigned it to you 👍

@Cronus1007
Copy link
Contributor

@d-e-v-esh Shall I look into this issue .

@naveen8801
Copy link

Hii @Michael-Grover , can i work on it ?

@naveen8801
Copy link

@d-e-v-esh , are you working on it ? ,

@d-e-v-esh
Copy link
Contributor

@naveen8801 No, you already created a PR right.

@naveen8801
Copy link

@d-e-v-esh , i have deleted previous one , because there was some issue in rest of UI while changing styles of Clause component . if you wanna work you can take your time , i can suggest you some changes which can be helpful :-)

@d-e-v-esh
Copy link
Contributor

@naveen8801 did you record what was going wrong? I'll work on this one next then and see if I can fix this.

@naveen8801
Copy link

@d-e-v-esh , after changing z-index , while hovering over slate in Contract editor , some icons such as edit , delete , dragger etc. were not visible . so there will be some other way of fixing this ,

@d-e-v-esh
Copy link
Contributor

@naveen8801 Ok... I'll take a look at that tomorrow

@K-Kumar-01
Copy link
Contributor

@d-e-v-esh
Are you going to work on the issue, as I am also able to reproduce it now

@d-e-v-esh
Copy link
Contributor

d-e-v-esh commented Mar 13, 2021

@K-Kumar-01 Ya, I'll work on this.

d-e-v-esh added a commit to d-e-v-esh/web-components that referenced this issue Mar 15, 2021
mttrbrts pushed a commit that referenced this issue Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants