Separated fit and transform steps. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one sequence has e.g. only CGT the old code will inconsistently assign integers to each letter if other sequences have all letters.
i.e. integer_encoder.fit_transform(list('CGT')) != integer_encoder.fit_transform(list('ACGT'))
Solution: grab alphabet of all letters in all sequences first and fit before transforming each sequence in loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one sequence has e.g. only CGT the old code will inconsistently assign integers to each letter if other sequences have a different set of letters (i.e. ACG or ACGT). Not problematic for long sequences which are very unlikely to not use all 4 letters, but if e.g. applying to small k-mers very likely to produce errors.
i.e. integer_encoder.fit_transform(list('CGT')) != integer_encoder.fit_transform(list('ACGT'))
Solution: grab alphabet of all letters in all sequences first and fit before transforming each sequence in loop.